fix: function 'unregister', someplace maybe inaccurate #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function `parent.getChild(key)` could return `undefined`
Update module-collection.js
ktsn
reviewed
Oct 17, 2018
| @@ -49,7 +49,7 @@ export default class ModuleCollection { | |||
| unregister (path) { | |||
| const parent = this.get(path.slice(0, -1)) | |||
| const key = path[path.length - 1] | |||
| if (!parent.getChild(key).runtime) return | |||
| if (!parent.getChild(key) || !parent.getChild(key).runtime) return | |||
There was a problem hiding this comment.
I prefer assertion rather than silently ignoring when the specified module does not exist. Can we change the implementation to that?
There was a problem hiding this comment.
I agree, maybe you can do it better latter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
parent.getChild(key)could returnundefined